Use HttpHeaderReader in RequestMessageReader and ResponseMessageReader #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in order to test the Http1HeaderReader api.
In order to use it properly I had to change the API of the
RequestMessageReaderandResponseMessageReaderto return aParseResult<T>. This leads to more verbose code, but that is natural when using error types in a language without good support for them. C# 9 should hopefully bring DUs which would make handling error cases less verbose.Other than that, my biggest difficulty was merging an API which took a
ReadOnlySequencewith one that was tracking position via aSequenceReader. There is no API to advance aSequenceReadertill aSequencePosition, so I had to remove usages ofSequenceReader.@davidfowl I'm interested in what you think?